Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a nox task to rustfmt code in the guide #2762

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add a nox task to rustfmt code in the guide #2762

merged 1 commit into from
Nov 22, 2022

Conversation

birkenfeld
Copy link
Member

Also apply it. Two caveats:

  1. needs nightly rustfmt to be available
  2. not all reformat diffs have been applied; using best judgment for readability

@birkenfeld birkenfeld added the CI-skip-changelog Skip checking changelog entry label Nov 20, 2022
adamreichold
adamreichold reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the regular expression is most likely much faster, but I have to admin to having trouble following the code. I suspect that a more manual line-by-line approach would be easier to read if more manual and slower.

noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@birkenfeld birkenfeld force-pushed the guidefmt branch 3 times, most recently from 2fb94c4 to 8110a47 Compare November 22, 2022 08:14
@birkenfeld
Copy link
Member Author

Switched to line-based, and I like it better too.

@birkenfeld
Add a nox task to rustfmt code in the guide.
a7a53d6 
Also apply it. Two caveats:

1) needs nightly rustfmt to be available
2) not all reformat diffs have been applied; using best judgment for readability.
@birkenfeld
Copy link
Member Author

birkenfeld commented Nov 22, 2022 •
edited
Loading

Thanks for the review! Now Github claims I'm not authorized to merge anymore... @davidhewitt is bors already active and mandatory?

@birkenfeld
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build succeeded:

@bors bors bot merged commit b485199 into main Nov 22, 2022
@adamreichold adamreichold deleted the guidefmt branch June 9, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkenfeld @adamreichold